Draft: what the JS/HTML template building might look like - #141
Closed
wegry wants to merge 5 commits into
Closed
Conversation
wegry
force-pushed
the
playground-runtime
branch
from
June 16, 2021 00:48
ff46436 to
b82c4d1
Compare
wegry
changed the title
Contributor
Author
|
@mariuswilms I think the basic concept is outlined here. It's very rough, but the biggest thing between getting this off the ground now is, I think, the parse/rewriting in I'll confess I'm tempted to say something like https://github.com/russross/blackfriday with https://pkg.go.dev/github.com/russross/blackfriday/v2#HTMLRenderer.RenderNode changed might fit our needs. |
mariuswilms
force-pushed
the
user-components
branch
2 times, most recently
from
August 20, 2021 10:50
1992b97 to
629149a
Compare
mariuswilms
force-pushed
the
user-components
branch
2 times, most recently
from
August 29, 2021 17:53
ea9c955 to
414385b
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like for the building and loading of playgrounds to look something like this list
stitches a module with a default export together with a very basic playground runtime.
Compile JS and HTML templates once instead of per request
extract playground instance source from the document tree
map playground instance source with a content hash
cache playground instance builds after the first
Figure out a way around loading React from a CDN. For now this uses
nodeLinker: node_modules.